Skip to content

fix(id): always compare legacy IDs below newly formatted IDs - #778

Open
mnoah1 wants to merge 1 commit into
preetam/numeric-resource-idsfrom
mnoah1/id-migration-compat
Open

mnoah1 wants to merge 1 commit into
preetam/numeric-resource-idsfrom
mnoah1/id-migration-compat

Conversation

@mnoah1

@mnoah1 mnoah1 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Update stovepipe's ID comparisons - place all legacy requests before the new numerical only value. This will avoid existing queues getting wedged when they hit the boundary between the last legacy request, and first new one.

Why?

Without this change, queues would have stalled at the boundary between the last legacy request bookmark, and the next incoming request in the new format. The comparison would have continually failed, and never drained out, because we are trying to compare a request in the old format, with a request in the new format.

What?

Adjust the request ID comparator to place all legacy requests before new ones in ordering.

Within each format, IDs retain numeric ordering. Decimal IDs sort after all valid legacy IDs; this assumes a one-way writer switch from legacy to decimal IDs.

Test Plan

  • Updated tests
  • During deployment, monitor that new requests continue to advance beyond the last legacy-formatted request.
  • ✅ Rebased the RFC → ID implementation → compatibility stack onto main (5b6af68f), preserving all eight commits and the compatibility patch's five-file scope.
  • ✅ make lint, make check-gazelle, make check-mocks, make check-tidy, make build, and make test (130 targets passed)
  • ✅ git diff --check
  • ⚠️ aifx verify could not complete its monorepo coverage, generic Go lint, and UReview API checks; repository-native checks above passed.

Stack

  1. docs: define scoped sequential resource IDs #762
  2. feat(ids): use queue-scoped decimal resource IDs #770
  3. @ fix(id): always compare legacy IDs below newly formatted IDs #778

@mnoah1
mnoah1 added this pull request to stack #771 October 5, 2026 20:36
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners October 5, 2026 20:36
@mnoah1 mnoah1 changed the title fix(id): preserve legacy IDs across decimal migration fix(id): always compare legacy IDs below newly formatted IDs Oct 5, 2026
@mnoah1
mnoah1 force-pushed the mnoah1/id-migration-compat branch from e7048c0 to 4f98510 Compare October 5, 2026 20:56
@behinddwalls
behinddwalls force-pushed the mnoah1/id-migration-compat branch from 4f98510 to 38c6495 Compare October 5, 2026 23:21

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants