Repository navigation
refactor(submitqueue): retire legacy entity JSON serializers - #780
Merged
Merged
Conversation
behinddwalls
marked this pull request as ready for review
October 5, 2026 23:25
behinddwalls
enabled auto-merge
October 5, 2026 23:25
mnoah1
approved these changes
Oct 6, 2026
## Summary ### Why? The internal queue migration landed in #703, but unused JSON serializers remained on the full Request, Batch, and Build entities. These are the final serialization helpers covered by #356; production publishers, consumers, and DLQ reconciliation already use the proto contracts. ### What? - Remove the remaining ToBytes/FromBytes helpers and their serializer-only tests, preserving lifecycle behavior tests and regenerating Bazel dependencies. - Verify unknown-field tolerance for all 11 current internal proto payloads without losing known fields. - Document the original hard-cutover rollout, including dead-letter handling and legacy enum/timestamp incompatibilities. This cleanup does not change the current wire format or message IDs. ## Test Plan - ✅ `./tool/bazel test //submitqueue/... //service/submitqueue/... --test_output=errors` — all 55 test targets pass, including contract, gateway, orchestrator, and DLQ tests. - ✅ `make lint`, `make check-tidy`, and `make check-gazelle`. - ✅ `./tool/bazel test //test/e2e/submitqueue:go_default_test --test_output=summary --sandbox_writable_path="$HOME/.docker" --test_filter=TestE2EIntegration` — fake-provider end-to-end suite, passing on retry after one invocation received RPC Unimplemented responses. The writable path permits macOS Docker buildx to update its activity file. - ✅ `./tool/bazel test //test/e2e/submitqueue:go_default_test --test_output=summary --sandbox_writable_path="$HOME/.docker" --test_filter='TestGitMergeE2E/TestLand_(SingleChange_ReachesTheTargetBranch|Stack_LandsInOrderInOneRefUpdate)'` — real-Git single-change and stacked-change cases pass with the cleanup. -⚠️ The combined E2E run encountered real-Git failures: Git rejected the Docker-mounted `/srv/git/sandbox.git` as having dubious ownership. The full `TestGitMergeE2E` suite also reproduces this on unchanged `main` at `276bfcc2`; its individual single-change/stack cases pass in isolation on that baseline. This pre-existing macOS/Docker ownership issue is outside the queue-contract cleanup. `aifx verify` passed its ureview/artifact checks but could not complete its Go lint/coverage adapters; coverage reports a missing `.arcconfig` in this OSS repository. Repository-native checks above are the validation source. ## Issue Closes #356 # Conflicts: # submitqueue/entity/batch_test.go # submitqueue/entity/request_test.go # Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # # interactive rebase in progress; onto 8ddc4c4 # Last command done (1 command done): # pick 31c46f1 # refactor(submitqueue): retire legacy entity JSON serializers # No commands remaining. # You are currently rebasing branch 'preetam/codex/356-retire-entity-serializers' on '8ddc4c49b'. # # Changes to be committed: # modified: submitqueue/core/messagequeue/README.md # modified: submitqueue/core/messagequeue/messagequeue_test.go # modified: submitqueue/entity/BUILD.bazel # modified: submitqueue/entity/batch.go # modified: submitqueue/entity/batch_test.go # modified: submitqueue/entity/build.go # modified: submitqueue/entity/build_test.go # modified: submitqueue/entity/request.go # modified: submitqueue/entity/request_test.go #
behinddwalls
force-pushed
the
preetam/codex/356-retire-entity-serializers
branch
from
October 6, 2026 20:55
b318492 to
0311a4b
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
The internal queue migration landed in #703, but unused JSON serializers remained on the full Request, Batch, and Build entities. These are the final serialization helpers covered by #356; production publishers, consumers, and DLQ reconciliation already use the proto contracts.
What?
Test Plan
./tool/bazel test //submitqueue/... //service/submitqueue/... --test_output=errors— all 55 test targets pass, including contract, gateway, orchestrator, and DLQ tests.make lint,make check-tidy, andmake check-gazelle../tool/bazel test //test/e2e/submitqueue:go_default_test --test_output=summary --sandbox_writable_path="$HOME/.docker" --test_filter=TestE2EIntegration— fake-provider end-to-end suite, passing on retry after one invocation received RPC Unimplemented responses. The writable path permits macOS Docker buildx to update its activity file../tool/bazel test //test/e2e/submitqueue:go_default_test --test_output=summary --sandbox_writable_path="$HOME/.docker" --test_filter='TestGitMergeE2E/TestLand_(SingleChange_ReachesTheTargetBranch|Stack_LandsInOrderInOneRefUpdate)'— real-Git single-change and stacked-change cases pass with the cleanup./srv/git/sandbox.gitas having dubious ownership. The fullTestGitMergeE2Esuite also reproduces this on unchangedmainat276bfcc2; its individual single-change/stack cases pass in isolation on that baseline. This pre-existing macOS/Docker ownership issue is outside the queue-contract cleanup.aifx verifypassed its ureview/artifact checks but could not complete its Go lint/coverage adapters; coverage reports a missing.arcconfigin this OSS repository. Repository-native checks above are the validation source.Issue
Closes #356