fix(git): preserve repository errors for orchestrator retries - #781
Open
Tmwakalasya wants to merge 1 commit into
Open
Tmwakalasya wants to merge 1 commit into
Tmwakalasya wants to merge 1 commit into
Conversation
Tmwakalasya
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 6, 2026 04:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The Git change provider calls
Repo.FetchTargetduring request validation. The repository execution helper formats Git failures as plain strings, discarding the operation, process error, and cancellation identity. A temporary DNS failure therefore cannot reach the existing Git retry policy, and a cancelled command no longer matchescontext.Canceled. The orchestrator also omits the Git classifier from its primary pipeline.What?
gitexec.CommandFailurehelper at the repository's raw-command and configuration-write boundaries, preserving error chains through contextual wrapping.Repo.FetchTargetwith a local fake executable feeding the production classifier list. No remote Git service is contacted by these tests.The existing classifier policy and public function signatures are unchanged. Configuration-write errors continue to add only the configuration key to their context, without including its value.
Test Plan
The new regression tests failed before the production changes and passed afterward.
go test -mod=readonlyforplatform/git/repo,platform/git/exec,platform/errs/..., the Git change provider, orchestrator server, validate controller, consumer, and pipeline packages../tool/bazel run @rules_go//go -- test -mod=readonly, using the pinned Go 1.25.0 toolchain.go vet -mod=readonly ./platform/git/repo ./service/submitqueue/orchestrator/server.make fmt lint,make check-tidy check-gazelle, andgit diff --check.SUBMITQUEUE_TEST_GIT=/usr/bin/gitand ran outside the macOS sandbox, whose warnings otherwise contaminate existing fixtures' combined output.SDKSettings.json; zero tests ran through those targets. Full-repository and Docker integration suites were not run.Issue
Found while tracing Git change-provider failures; no existing issue linked.