Custom JsonConverter: .NET 10 and registration tests - #2260
Open
vladimir-pecanac-main wants to merge 1 commit into
Open
vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
- Retarget both projects from net7.0 to net10.0. - Newtonsoft.Json 13.0.3 to 13.0.4. - Test packages: Microsoft.NET.Test.Sdk 18.10.1, xunit 2.9.3, xunit.runner.visualstudio 4.0.0, coverlet.collector 10.1.0. - Remove the unused Microsoft.AspNetCore.Mvc.Testing reference. - Drop the CanWrite and CanRead overrides from SmartContactConverter; both repeat the base class defaults. - Add ConverterRegistrationUnitTest: a converter registered through JsonSerializerSettings.Converters, and a type carrying the JsonConverter attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample update for the article "How to Create a Custom JsonConverter in Json.NET" (https://code-maze.com/json-dotnet-create-custom-jsonconverter/). Touches only json-csharp/CustomJsonConverter.
Changes:
Package versions, re-queried on NuGet on 2026-10-04 (newest stable on that day):
Local run on SDK 10.0.302, runtime 10.0.10: build 0 warnings 0 errors, dotnet test Passed 6, Failed 0. dotnet list package --vulnerable --include-transitive reports nothing for either project.