Skip to content

Custom JsonConverter: .NET 10 and registration tests #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vladimir-pecanac-main wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Custom JsonConverter: .NET 10 and registration tests #2260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions json-csharp/CustomJsonConverter/CustomJsonConverter.Tests/ConverterRegistrationUnitTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
using CustomJsonConverter.Converters;
using Newtonsoft.Json;
using Xunit;

namespace CustomJsonConverter.Tests;

[JsonConverter(typeof(ImprovedContactConverter))]
public record class TaggedContact(string Name, Department Department, string Phone, Address Address)
: Contact(Name, Department, Phone, Address);

public class ConverterRegistrationUnitTest
{
[Fact]
public void GivenListOfContacts_WhenConverterIsRegisteredInSettings_ThenWritesCustomizedOutput()
{
var contacts = DataSource.GetContacts();
var settings = new JsonSerializerSettings
{
Converters = { new SmartContactConverter() }
};

var json = JsonConvert.SerializeObject(contacts, settings);

Assert.Equal(@"[{""Name"":""John"",""Department"":""Admin"",""Address"":{""Street"":""Street 1"",""City"":""City 1""}},{""Name"":""Jane"",""Department"":""CustomerCare"",""Phone"":""+2341"",""Address"":{""Street"":""Street 2"",""City"":""City 2""}},{""Name"":""Mike"",""Department"":""Operations"",""Address"":{""Street"":""Street 3"",""City"":""City 3""}}]", json);
}

[Fact]
public void GivenTypeWithConverterAttribute_WhenRoundTripped_ThenConverterWritesAndDefaultContractReads()
{
var contact = new TaggedContact("John", Department.Admin, "+1234", new("Street 1", "City 1"));

var json = JsonConvert.SerializeObject(contact);

Assert.Equal(@"{""Name"":""John"",""Department"":1}", json);

var restored = JsonConvert.DeserializeObject<TaggedContact>(json)!;

Assert.Equal("John", restored.Name);
Assert.Equal(Department.Admin, restored.Department);
Assert.Null(restored.Phone);
}
}
13 changes: 6 additions & 7 deletions json-csharp/CustomJsonConverter/CustomJsonConverter.Tests/CustomJsonConverter.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="7.0.3" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.10.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="3.2.0">
<PackageReference Include="coverlet.collector" Version="10.1.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
4 changes: 0 additions & 4 deletions json-csharp/CustomJsonConverter/CustomJsonConverter/Converters/SmartContactConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,4 @@ public override void WriteJson(JsonWriter writer, Contact? contact, JsonSerializ

return jo.ToObject<Contact>();
}

public override bool CanWrite => true;

public override bool CanRead => true;
}
4 changes: 2 additions & 2 deletions json-csharp/CustomJsonConverter/CustomJsonConverter/CustomJsonConverter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
</ItemGroup>

</Project>
Loading