Repository navigation
Conversation
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 21 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 69 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Comment |
|
Independent confirmation from cc-cli-w3: I reproduced this exact pin from |
…pe fixes Rollout relays for cloud-commitments-go #218 (fix(azure): stop dividing the monthly run-rate by the term months, merged as e24345c) and #207 (fix(azure): report only savings plans billed to the subscription, merged as 58c25f0). Pin providers/azure at v0.0.0-20261007133317-58c25f04c49b, which contains both fixes, and pkg at the version the azure module requires. The aws and gcp pins stay where they are so no module moves backwards. Error-handling audit for the #207 semantics change (GetExistingCommitments for Azure savings plans can now fail instead of returning a silently partial list): every CLI call to GetExistingCommitments goes through provider.ServiceClient instances built by createServiceClient, which dispatches AWS services only, so no CLI path calls the Azure inventory today. The duplicate-purchase guards that do consume the interface (checkDuplicates, checkDuplicatesForCSVRegion) already fail closed on error for purchase runs. Coordinated with #2121: that issue's broader deps adoption should build on this branch or exclude the azure pin.
|
cc-cli-w3 relay follow-up: orchestrator relayed cloud-commitments-go #207 ( I checked the CLI's call sites against that contract:
Suggestion to avoid a second churn on the same go.mod line (fleet note: #2143 also touches go.mod/go.sum): consider bumping this PR's azure pin from |
ce1ac3a to
86f6a6f
Compare
|
Codex takeover audit: head remains 86f6a6f; CI re-fetched green and merge state CLEAN. Recovered independent review used kimi-code/k3 at ce1ac3a, before the rebase and Azure repin to 58c25f04c49b. It does not satisfy the exact claude-opus-5-5 review at the current SHA required by CLAUDE.md. Direct invocation of the pinned reviewer failed: Not logged in; Please run /login. Merge is held pending that exact-model full-diff review and verdict recorded here. The owner CodeRabbit quota waiver does not waive the reviewer gate. Existing build/full-suite evidence is preserved in the prior session history; no duplicate push or new CR trigger performed. |
Summary
Rollout relays from the PR-fleet orchestrator for two cloud-commitments-go Azure fixes:
fix(azure): stop dividing the monthly run-rate by the term months(merged ase24345c)fix(azure): report only savings plans billed to the subscription(merged as58c25f0)This PR pins the CLI's azure providers module at
v0.0.0-20261007133317-58c25f04c49b, which contains both fixes:providers/azure->v0.0.0-20261007133317-58c25f04c49b(the fix(dashboard): wire upcoming-purchase buttons to plan endpoints (closes #204, #205) #207 merge; descends from the feat(aws/recs): populate ComputeDetails.VCPU + MemoryGB via DescribeInstanceTypes catalogue #218 merge)pkg->v0.0.0-20261006104817-90e61e668b99(required by the azure module's go.mod)providers/awsandproviders/gcppins unchanged, so no module moves backwards#207 error-handling audit
#207 changes
GetExistingCommitmentsfor Azure savings plans to fail closed (error instead of a silently partial list). Audit of this repo: everyGetExistingCommitmentscall goes throughprovider.ServiceClientvalues built bycreateServiceClient(cmd/main.go:242), which dispatches AWS services only, so no CLI code path calls the Azure inventory today. The two duplicate-purchase guards that consume the interface (checkDuplicatesin cmd/multi_service_helpers.go,checkDuplicatesForCSVRegionin cmd/multi_service.go) already refuse to purchase when the check errors.Coordination
Delta scope (from independent review)
The previous azure pin (
56555e1be095) was the tip of a stacked branch, not a main commit, so this bump adopts more than the two relayed fixes. Main-only azure changes included: #209 (applied scope through RI exchange), #217 (drop Advisor recommendations with unparsable savings), #240, #246/#251 (pager caps), #259 (unknown Managed Redis payment option now hard-errors instead of passing through), plus #218 and #207. Net behavior change is a strict improvement, but operators should know #259 turns a previously silent pass-through into an error.The
pkgbump is ~60 commits ahead of what the pinned aws/gcp modules declare and includes a breaking change (ExistingCommitmentadded toPurchaseResult, cloud-commitments-go #261). The CLI builds and vets clean against it; no aws/gcp pin moves.Verification
make build: passed on the rebased head.go test ./...): passed, 446s, on the exact rebased head 86f6a6f.go mod tidycheck).No live cloud calls; dependency pin change only.