Skip to content

test(recommendations): cover expiry through command output - #2143

Open
cristim wants to merge 4 commits into
mainfrom
codex/go70-cli-expiry-command
Open

cristim wants to merge 4 commits into
mainfrom
codex/go70-cli-expiry-command

Conversation

@cristim

@cristim cristim commented Oct 7, 2026

Copy link
Copy Markdown
Member

Reopening of #2134 (closed unmerged when its base branch codex/go70-cli-expiry-consumer was deleted after #2133 merged). Same branch, retargeted at main. Original: test(recommendations): cover expiry through command output. Needs a rebase onto main to absorb #2133 and #2135.

Use the coverage-aware AWS API and report missing-demand skips.
Pin the published exact-coverage prerequisites and test helper sizing.

This is the consumer prerequisite for issue 70; command-level proof
is retained in the separate verification layer. Real-scenario
acceptance and final dependency repins remain outstanding.
Exercise pool demand, missing demand, filtering and exact boundaries
through the existing root-command, TLS SDK and CSV test harness.
Assert counts, costs, warnings and the bounded request allowlist.

This verification layer depends on the consumer prerequisite and uses
synthetic provider responses. Real-scenario acceptance and final
dependency repins remain outstanding.

Refs LeanerCloud/cloud-commitments-go#70.
@cristim cristim added triaged Item has been triaged priority/p1 Next up; this sprint severity/medium Moderate harm urgency/this-sprint Within the current sprint impact/many Affects most users effort/s Hours type/bug Defect labels Oct 7, 2026
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 6 billable files and costs up to $1.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 3 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 69 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: c9f7bb60-06b6-472c-89f3-9b251add9db3
📥 Commits

Reviewing files that changed from the base of the PR and between 65a02a7 and 1ee2d19.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (6)
  • cmd/multi_service_helpers.go
  • cmd/recommendation_completeness_proxy_test.go
  • cmd/recommendation_completeness_test.go
  • cmd/reservation_expiry_command_test.go
  • cmd/reservation_expiry_test.go
  • go.mod
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours impact/many Affects most users priority/p1 Next up; this sprint severity/medium Moderate harm triaged Item has been triaged type/bug Defect urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant