Repository navigation
Require passing checks before publishing #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rcosta358
merged 5 commits into
codex/issue-125-test-workflow
from
codex/issue-126-required-checks
Oct 7, 2026
+119
−52
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a982bd1
Require checks before publishing the extension
rcosta358 0a11108
Merge remote-tracking branch 'origin/codex/issue-125-test-workflow' i…
rcosta358 00fd1f4
Publish the extension artifact produced by checks
rcosta358 c7a9490
Create release pull requests before tagging
rcosta358 ec0fb32
Merge branch 'codex/review-stack-138' into codex/review-stack-139
rcosta358 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,113 @@ | ||
| #!/bin/bash | ||
| #!/usr/bin/env bash | ||
|
|
||
| VERSION=$1 | ||
| set -euo pipefail | ||
|
|
||
| # check valid version format | ||
| if [ -n "$VERSION" ] && [[ ! $VERSION =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | ||
| echo "Version must be in format 1.2.3" | ||
| usage() { | ||
| echo "Usage: ./release.sh [VERSION] | ./release.sh --tag VERSION" >&2 | ||
| } | ||
|
|
||
| MODE="pr" | ||
| if [[ "${1:-}" == "--tag" ]]; then | ||
| MODE="tag" | ||
| shift | ||
| fi | ||
|
|
||
| if [[ $# -gt 1 ]] || [[ "$MODE" == "tag" && $# -ne 1 ]]; then | ||
| usage | ||
| exit 1 | ||
| fi | ||
|
|
||
| VERSION="${1:-}" | ||
| if [[ -n "$VERSION" && ! "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | ||
| echo "Version must be in format 1.2.3" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| # check current branch | ||
| CURRENT_BRANCH=$(git branch --show-current) | ||
| if [ "$CURRENT_BRANCH" != "main" ]; then | ||
| echo "Releases can only be created from the main branch (current: $CURRENT_BRANCH)" | ||
| if [[ "$CURRENT_BRANCH" != "main" ]]; then | ||
| echo "Releases must start from main (current: $CURRENT_BRANCH)" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| # bump patch version if no version provided | ||
| if [ -z "$VERSION" ]; then | ||
| (cd client && npm version patch --no-git-tag-version) | ||
| VERSION=$(node -p "require('./client/package.json').version") | ||
| if [[ -n "$(git status --porcelain)" ]]; then | ||
| echo "Releases require a clean working tree" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| # check if version present in package.json | ||
| if ! grep -q "\"version\": \"$VERSION\"" ./client/package.json; then | ||
| echo "Version $VERSION not found in package.json" | ||
| git pull --ff-only origin main | ||
| if [[ "$(git rev-parse HEAD)" != "$(git rev-parse origin/main)" ]]; then | ||
| echo "Local main must match origin/main before releasing" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| # check if version tag already exists | ||
| if git rev-parse "v$VERSION" >/dev/null 2>&1; then | ||
| echo "Release $VERSION already exists" | ||
| if [[ "$MODE" == "tag" ]]; then | ||
| CURRENT_VERSION=$(node -p "require('./client/package.json').version") | ||
| if [[ "$CURRENT_VERSION" != "$VERSION" ]]; then | ||
| echo "Version $VERSION is not the version on main ($CURRENT_VERSION)" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| if git rev-parse --quiet --verify "refs/tags/v$VERSION" >/dev/null; then | ||
| echo "Release $VERSION already exists" >&2 | ||
| exit 1 | ||
| fi | ||
| REMOTE_TAG=$(git ls-remote --tags origin "refs/tags/v$VERSION") | ||
| if [[ -n "$REMOTE_TAG" ]]; then | ||
| echo "Release $VERSION already exists" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| git tag -a "v$VERSION" origin/main -m "vscode-liquidjava $VERSION" | ||
| git push origin "refs/tags/v$VERSION" | ||
| exit 0 | ||
| fi | ||
|
|
||
| if ! command -v gh >/dev/null 2>&1; then | ||
| echo "GitHub CLI (gh) is required to create the release pull request" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| git pull | ||
| git add . | ||
| if [[ -z "$VERSION" ]]; then | ||
| VERSION=$(node -e 'const [major, minor, patch] = require("./client/package.json").version.split(".").map(Number); console.log(`${major}.${minor}.${patch + 1}`)') | ||
| fi | ||
|
|
||
| CURRENT_VERSION=$(node -p "require('./client/package.json').version") | ||
| if [[ "$CURRENT_VERSION" == "$VERSION" ]]; then | ||
| echo "Version $VERSION is already on main; choose a new version" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| BRANCH="codex/release-$VERSION" | ||
| if git show-ref --verify --quiet "refs/heads/$BRANCH"; then | ||
| echo "Release branch $BRANCH already exists" >&2 | ||
| exit 1 | ||
| fi | ||
| REMOTE_BRANCH=$(git ls-remote --heads origin "refs/heads/$BRANCH") | ||
| if [[ -n "$REMOTE_BRANCH" ]]; then | ||
| echo "Release branch $BRANCH already exists" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| if git rev-parse --quiet --verify "refs/tags/v$VERSION" >/dev/null; then | ||
| echo "Release $VERSION already exists" >&2 | ||
| exit 1 | ||
| fi | ||
| REMOTE_TAG=$(git ls-remote --tags origin "refs/tags/v$VERSION") | ||
| if [[ -n "$REMOTE_TAG" ]]; then | ||
| echo "Release $VERSION already exists" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| git switch -c "$BRANCH" | ||
| (cd client && npm version "$VERSION" --no-git-tag-version >/dev/null) | ||
| git add client/package.json client/package-lock.json | ||
| git commit -m "Release $VERSION" | ||
| git tag -a "v$VERSION" -m "vscode-liquidjava $VERSION" | ||
| git push --set-upstream origin "$BRANCH" | ||
|
|
||
| gh pr create \ | ||
| --base main \ | ||
| --head "$BRANCH" \ | ||
| --title "Release $VERSION" \ | ||
| --body "Prepare version $VERSION for release. Merge this pull request after Checks pass, then run ./release.sh --tag $VERSION from main to publish." | ||
|
|
||
| git push | ||
| git push --tags | ||
| printf 'After the release pull request is merged, run ./release.sh --tag %s from main to publish.\n' "$VERSION" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The published VSIX is rebuilt differently from the one the checks tested. After
needs: checks, the publish job builds again with JDK 20 (checks use 21),npm installinstead ofnpm ci, andvsce package --no-dependenciesinstead ofvsce package. So the shipped artifact isn't the one that passed: a lockfile drift, a JDK difference or a dependency-bundling difference would only show up in the release.Suggest either aligning the steps (same JDK,
npm ci, samevsceflags), or uploading the VSIX from the checks job as an artifact and publishing exactly that file.(As the PR description says, requiring
Checksonmainis still a repo-settings step. See also the skipped-job note on #138, which affects that required check.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 00fd1f4: checks upload the validated VSIX, and both marketplaces publish that exact downloaded file without rebuilding. Workflow/artifact checks, packaged runtime checks, and extension installation passed.