Repository navigation
Require passing checks before publishing - #139
Conversation
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Publishing now waits for the checks. One gap between what's checked and what ships:
Reviewed with Claude Code (reviewer + adversarial agents per PR, findings checked against the code before posting).
| uses: ./.github/workflows/test.yml | ||
|
|
||
| publish: | ||
| needs: checks |
There was a problem hiding this comment.
The published VSIX is rebuilt differently from the one the checks tested. After needs: checks, the publish job builds again with JDK 20 (checks use 21), npm install instead of npm ci, and vsce package --no-dependencies instead of vsce package. So the shipped artifact isn't the one that passed: a lockfile drift, a JDK difference or a dependency-bundling difference would only show up in the release.
Suggest either aligning the steps (same JDK, npm ci, same vsce flags), or uploading the VSIX from the checks job as an artifact and publishing exactly that file.
(As the PR description says, requiring Checks on main is still a repo-settings step. See also the skipped-job note on #138, which affects that required check.)
There was a problem hiding this comment.
Fixed in 00fd1f4: checks upload the validated VSIX, and both marketplaces publish that exact downloaded file without rebuilding. Workflow/artifact checks, packaged runtime checks, and extension installation passed.
…nto codex/issue-126-required-checks
Co-authored-by: Codex <noreply@openai.com>
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
If Checks becomes required on main, release.sh will break, since it pushes the "Release X" commit directly to main and that commit has no status yet. We would need to release via a PR or give releasers bypass. Minor: the ~69 MB .vsix artifact is now uploaded on every branch push; retention-days: 1 should be enough since publish uses it in the same run.
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
|
Addressed the release and retention feedback in ec0fb32: A disposable repository simulation verified the prepare → merge → tag flow. Shell/workflow checks, extension installation, independent review, and the new CI run passed. |
Adds 25 Vitest/jsdom tests for diagnostics, context sections, and state machine rendering, including diagram controls and condition expansion. CI runs unit tests and checks their types; test files and configuration stay out of the extension package. Validation: unit tests, lint, production/test type checks, VSIX inspection, and extension installation passed. Depends on #139. Closes #127. Generated by Codex. --------- Co-authored-by: Codex <noreply@openai.com>
## Description Closes #134. Add weekly and manual Windows/macOS runs for client and server unit tests plus VS Code stable integration tests, with logs uploaded on failure. The diff contains only `platform-tests.yml`. ## Related Issues Depends on #146. The existing prerequisite PRs now form one chain through #145, #144, #143, #141, #142, #140, #139, #138, and #137 to main. The schedule becomes active when merged to the default branch. Validation: 32 client tests, 24 server tests, lint, production/test TypeScript checks, and extension installation passed. Stable and minimum VS Code integration passed in [PR CI](https://github.com/liquid-java/vscode-liquidjava/actions/runs/37541530280). Fresh [Windows/macOS validation](https://github.com/liquid-java/vscode-liquidjava/actions/runs/37541530341) passed on the final commit, including both unit-test suites and VS Code integration. 🤖 Generated with [Codex](https://openai.com/codex/) --------- Co-authored-by: Codex <noreply@openai.com>
2 participants
Part of #126. Depends on #138.
Publish the exact VSIX produced by the reusable checks workflow. Prepare releases through a version-bump PR, then tag the merged main commit with
./release.sh --tag VERSION. Retain checked artifacts for one day. A repository administrator still needs to require Checks on main.Validated shell/workflow syntax, extension installation, and a disposable repository simulation of the release PR and post-merge tag flow.
🤖 Generated with Codex