Repository navigation
Conversation
zmofei
changed the title
zmofei
added
the
locationai-team-skills
This was referenced Oct 8, 2026
One fixed palette for help, tables, tips and the banner, every color at the same mid luminance so it reads on light and dark themes, falling back to bold where 24-bit color is not known to render. AGI-1174
A fixed accent sits at mid luminance to read on light themes, which made headings darker than the reader's text on dark ones and clashed with their theme's hue. AGI-1174
zmofei
changed the title
The accent is only ever bold, so it needs 3:1 rather than 4:1; at 0.26 luminance it is the brightest blue of its hue still at 3:1 on every theme measured. --no-color is read off argv before the parse, since help is rendered during it. AGI-1169 AGI-1174
Help asks the terminal for its background (OSC 11) and uses a palette for a dark or a light one; other runs, and help where the terminal doesn't answer, keep the palette that reads on both. Only help asks: the answer is read off the terminal's input, and a command that prompts afterwards lost the answer typed ahead. Every colored run of text is bold. AGI-1169 AGI-1174
As cf --help does: help is the page read most, and the version is often what the reader came for. stderr, at a terminal, and -q still hides it. AGI-1174
One row per product, every sparkline the width of the period, bars scaled from zero and capped at the seven-eighths block so rows don't run together. Title, bars and tips use the palette; the footer is one line; TOTAL lines up under its header.
zmofei
changed the title
Tileset hosting at 1 a day with one day at 0 failed the every-day-equal test and scaled every 1 to the top glyph.
Each product is to its own scale, so a series with one value is at its busiest every day; the cap at the seven-eighths block already keeps it off the row above.
Every row is to its own scale, so the tallest bar means a different number on each; say which after the line, as Tufte labels a sparkline.
zmofei
marked this pull request as ready for review
October 8, 2026 14:59
zmofei
changed the title
mattpodwysocki
approved these changes
Oct 8, 2026
mattpodwysocki
left a comment
mattpodwysocki
left a comment
Contributor
There was a problem hiding this comment.
Ran the real output, not just the diff: the grouping, column alignment, learn-more links (agent-setup/prompt.md included, that's a real 200 now that #199 is in), --no-color/NO_COLOR/FORCE_COLOR, and the usage sparklines all work as described. The Windows handling is the part I cared most about given the arm64 build work going on elsewhere right now, and it's solid: console_renders_ansi gates raw escapes to terminals that actually advertise VT support, the OSC 11 query is bounded to 100ms and only runs during --help, and it falls back to the mid-luminance palette rather than guessing. every_command_has_a_place genuinely catches an unassigned command too.
Two small corrections for the description, neither blocks anything:
- "fits at 80 columns" isn't quite what's shipped, MAX_WIDTH is 100 (help_layout.rs:108, main.rs:439 caps clap the same way), and the real -o, --output line runs to 99 characters.
- #86 isn't closed/superseded the way #84/#85/#87 are, it's merged, just into this branch rather than main. Content's all here either way, just worth saying "merged into this branch" rather than "replaces" for that one.
Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
mapbox --help, command help andmapbox usageeasier to read. Replaces #84, #85, #86 and #87.Help
src/help_layout.rs; a test fails if a new command isn't in one.Color
cfCLI. Help picks a light or dark palette from the terminal's background.--no-colorflag andFORCE_COLORsupport.mapbox usagepeak 2,618,385/day).Before / After
Top-level:
mapbox --helpSubcommand:
mapbox tilesets query --helpTesting
The test suite passes, with and without a coding agent detected. Help fits at 80 columns and all links work.
Not checked: Windows terminals beyond CI, and which terminals answer the background color query.