Repository navigation
Conversation
Member
Author
|
Merged into #83 so the top-level help changes can be reviewed together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top-level
--helpprinted each option on one line however long, so five lines ran past 100 columns and an 80-column terminal folded them back to column 0. This turns on clap'swrap_help: help wraps to the terminal width, or 100 columns when stdout isn't a terminal.Env-backed options also read
[env: MAPBOX_USERNAME=]when unset and printed the variable's value when set; only--tokenhid it. All of them now read[env: NAME]. The two hand-written notes on--timeoutand--outputdrop their=to match.wrap_helpadds four crates toCargo.lock:terminal_size,rustix,errno,linux-raw-sys.Verified: both new tests fail with the change backed out; checked help output piped and with
COLUMNS=80.Not checked: Windows terminal-width detection (CI only), and
cargo-auditon the new crates until CI runs.