Skip to content

feat(api): define Stovepipe List contract - #775

Merged
behinddwalls merged 10 commits into
mainfrom
mnoah1/stovepipe-list-api-rfc
Oct 5, 2026
Merged

behinddwalls merged 10 commits into
mainfrom
mnoah1/stovepipe-list-api-rfc

Conversation

@mnoah1

@mnoah1 mnoah1 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add the List protobuf contract and generated bindings alongside a concise RFC.
  • Align RequestSummary's shared wire fields with project status; its existing response stays unchanged and refactoring is deferred.
  • Define ordering, time defaults, summary fields, pagination, and required data access paths; controller and storage implementation remain deferred.
  • Remove unrelated README and history-document changes.
  • Listing is time-only; older requests lacking acceptance-time data are excluded until repaired or backfilled.

Test Plan

Proto generation, repository lint/dependency/BUILD checks, Stovepipe server build, and all 22 existing Stovepipe unit-test targets passed. Markdown links and diff whitespace checked.

Revert Plan

Revert this PR; no List controller or storage implementation is introduced.

Issues

Issue Links

None — contract proposal; no ticket on this branch.

mnoah1 added 2 commits October 5, 2026 17:58
Summary:
Intent:
- Define a review-ready List contract without tying storage to SQL secondary indexes.
- Distinguish existing request data from the projections and access paths still needed.

Changes:
- Specify queue-scoped request-ID and acceptance-time ordering, optional time bounds, summary fields, and cursor pagination.
- Describe canonical acceptance time and outcome reason in summaries, with an immutable time-to-request mapping for timestamp selection.
- Document bounded reads, numeric-key migration, idempotent repair, rollout coverage, and deferred features.
- Align the history RFC and storage guide with existing materialization and register the new RFC.
- Documentation only; RPC and storage implementation remain proposed.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
@mnoah1 mnoah1 changed the title docs(stovepipe): define List API contract and portable time lookup feat(api): define Stovepipe List contract Oct 5, 2026
Comment thread api/stovepipe/proto/stovepipe.proto Outdated
Comment thread api/stovepipe/proto/stovepipe.proto Outdated
@mnoah1
mnoah1 requested a review from behinddwalls October 5, 2026 18:48
Comment thread doc/rfc/stovepipe/list-api.md
@mnoah1
mnoah1 marked this pull request as ready for review October 5, 2026 19:14
@mnoah1
mnoah1 requested review from a team and sbalabanov as code owners October 5, 2026 19:14
@mnoah1
mnoah1 enabled auto-merge October 5, 2026 19:39
@mnoah1
mnoah1 added this pull request to the merge queue Oct 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 5, 2026
@behinddwalls
behinddwalls added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit 83352cd Oct 5, 2026
16 checks passed
@behinddwalls
behinddwalls deployed to stack-rebase October 5, 2026 23:08 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the mnoah1/stovepipe-list-api-rfc branch October 5, 2026 23:08

This branch was successfully deployed

1 active deployment
stack-rebase — d6c30463 Deployed Oct 5, 2026 by behinddwalls via Rebase Stack #558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants